Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversions between rpm, rps, and other rotational units. #268

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

ajkeller34
Copy link
Collaborator

Closes #261.

@codecov-io
Copy link

codecov-io commented Sep 1, 2019

Codecov Report

Merging #268 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   78.32%   78.34%   +0.02%     
==========================================
  Files          15       15              
  Lines        1075     1076       +1     
==========================================
+ Hits          842      843       +1     
  Misses        233      233
Impacted Files Coverage Δ
src/pkgdefaults.jl 20.4% <ø> (ø) ⬆️
src/user.jl 94.69% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbfc6e...f496d17. Read the comment docs.

- Correct definition of `Hz`
@ajkeller34
Copy link
Collaborator Author

I'd like to keep this open for a couple days to see if there are any objections. In particular, I think the previous definition of Hz was also wrong. I'm surprised nobody complained about it before given how common of a unit Hz is, which is why I'm nervous to merge this.

src/pkgdefaults.jl Outdated Show resolved Hide resolved
@ajkeller34 ajkeller34 merged commit f55d1eb into PainterQubits:master Sep 2, 2019
@ajkeller34 ajkeller34 deleted the fixrot branch September 2, 2019 01:55
@gustaphe
Copy link
Contributor

gustaphe commented Jun 9, 2022

I know I'm a bit late to the party but I do object to this. I would expect 60rpm == 1Hz == 1/s. To get an angular frequency (in radians/minute) corresponding to 1 revolution per minute, you take ω = 2π*f. This tripped me up bad recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conversion from RPM to rad/s is incorrect
4 participants