Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: multi-level snapshot comparison and config parser refactor #128

Merged
merged 16 commits into from
Aug 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update panos_upgrade_assurance/utils.py
Co-authored-by: Łukasz Pawlęga <42772730+FoSix@users.noreply.github.com>
  • Loading branch information
alperenkose and FoSix authored Aug 14, 2023
commit 6d7c0ac0541b6549541bde654a0491aacfe9026f
2 changes: 1 addition & 1 deletion panos_upgrade_assurance/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def __init__(
* if `requested_config` is `None` we immediately treat it as if `all` was passed implicitly
(see [`dialect`](/panos/docs/panos-upgrade-assurance/dialect)) - it's expanded to `valid_elements`
* `_requested_config_names` is introduced as `requested_config` stripped of any element configurations. Additionally, we
do verification if all elements of this variable match `valid_elements`, if not, an exception is thrown by default.
do verification if all elements of this variable match `valid_elements`, if they do not, an exception is thrown by default.
`request_config` is checked at top level level key in case of nested dictionaries within the list.
* if `ignore_invalid_config` is set to `True`, we ignore any invalid configurations passed in the `requested_config` -
(no exception thrown) and we remove these invalid configurations from `_requested_config_names` and
Expand Down
Loading