Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bgp peers snapshot comparison #154

Merged
merged 6 commits into from
Feb 21, 2024
Merged

feat: bgp peers snapshot comparison #154

merged 6 commits into from
Feb 21, 2024

Conversation

acelebanski
Copy link
Contributor

Description

On customer's request, added BGP peers information to FW snapshot. This PR introduces BGP peers information comparison with emphasis on BGP session status.

Motivation and Context

#150

How Has This Been Tested?

It has been tested with example python scripts.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@acelebanski acelebanski linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1065 1045 98% 95% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
panos_upgrade_assurance/check_firewall.py 97% 🟢
panos_upgrade_assurance/firewall_proxy.py 99% 🟢
panos_upgrade_assurance/snapshot_compare.py 99% 🟢
panos_upgrade_assurance/utils.py 98% 🟢
TOTAL 98% 🟢

updated for commit: ae589f8 by action🐍

Copy link

github-actions bot commented Feb 8, 2024

A Preview PR in PanDev repo has been created. You can view it here.

Copy link
Collaborator

@adambaumeister adambaumeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Alp Eren Kose <alperenkose@gmail.com>
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  panos_upgrade_assurance
  firewall_proxy.py
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

Co-authored-by: Alp Eren Kose <alperenkose@gmail.com>
@acelebanski acelebanski merged commit 4fec622 into main Feb 21, 2024
7 checks passed
@acelebanski acelebanski deleted the 150-bgp-peers branch February 21, 2024 10:07
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
## [0.3.4](v0.3.3...v0.3.4) (2024-03-07)

### Features

* bgp peers snapshot comparison ([#154](#154)) ([4fec622](4fec622))

### Bug Fixes

* calculate_diff_on_dicts to Support Integer Values for ARP Table ttl ([#153](#153)) ([47ebea5](47ebea5))
* **firewall_proxy/is_panorama_connected:** Added fix for panorama check for FWs in version PAN-OS 11 or later ([#159](#159)) ([e617dbc](e617dbc))
* route snapshot missing entries fix ([#146](#146)) ([d946462](d946462))
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 0.3.4 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BGP peerings snapshot
4 participants