Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker image build scripts #30

Merged
merged 5 commits into from
May 10, 2023
Merged

docker image build scripts #30

merged 5 commits into from
May 10, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Apr 27, 2023

Docker file + a shell script to build an image with latest build of the upgrade assurance libraries

docker_image/build.sh Outdated Show resolved Hide resolved
docker_image/build.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@adambaumeister adambaumeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the following changes in #33, which were required for XSOAR support. Not sure if the removal of the entrypoint is explictly required though, so I can retest that if required,

@FoSix
Copy link
Contributor Author

FoSix commented May 9, 2023

Not sure if the removal of the entrypoint is explictly required though, so I can retest that if required,

@adambaumeister The image is not meant to be run outside of XSOAR, for now. I think we can skip ENTRYPOINT. We can always provide additional Dockerfiles if required.

I'll merge #33

@FoSix FoSix merged commit 99e2d5d into main May 10, 2023
@FoSix FoSix deleted the docker_image branch May 10, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants