Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix get_licenses function parsing #9

Merged
merged 1 commit into from
Feb 16, 2023
Merged

bug: fix get_licenses function parsing #9

merged 1 commit into from
Feb 16, 2023

Conversation

horiagunica
Copy link
Collaborator

@horiagunica horiagunica commented Feb 16, 2023 •
edited
Loading

Description

Motivation and Context

  • Fix licensing parsing issue .

How Has This Been Tested?

  • Re-run the snapshot taking with firewall containing a single element and also more elements for the licensing.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • All new and existing tests passed.

FoSix
FoSix approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@FoSix FoSix merged commit 62289d9 into main Feb 16, 2023
@FoSix FoSix deleted the 8-bug-get_licenses-dict-transformation branch February 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoSix FoSix FoSix approved these changes

@alperenkose alperenkose Awaiting requested review from alperenkose alperenkose is a code owner

@adambaumeister adambaumeister Awaiting requested review from adambaumeister adambaumeister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: get_licenses error with a single element in the list
2 participants
@horiagunica @FoSix