Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bunch of icons for file types used in programming #3460

Merged
merged 11 commits into from
Aug 4, 2023

Conversation

sennoth
Copy link
Contributor

@sennoth sennoth commented Jun 22, 2023

Proposed icons

  • CoffeeScript file .coffee
  • CoffeeScript object notation file .cson
  • CBOR serialised content .cbor
  • Stylus CSS preprocessor .styl
  • VueJS single file component .vue
  • Recipes file for Just command runner .justfile
  • WebAssembly file .wasm
  • Vlang source file .v

@SmartFinn
Copy link
Member

Thanks for the contribution.

It's hard to make the detail review to the PR. I'm just pointing on several issues that should be fixed:

  1. Blurring objects on the icons. It may be fixed by align objects by the pixel grid (Shift-3 in Inkscape) (e.g. text-x-stylus.svg and application-x-cson.svg, only 64px is OK), or reducing count of objects (e.g. application-cbor.svg and application-wasm.svg) or object simplification (e.g. removing holes on the cup in text-x-coffeescript.svg for 16-32px sizes).
  2. Papirus style doesn't allow using gradients for icons. Please replace the gradients with opacity on text-x-coffeescript.svg and text-x-vsrc.svg).

Here is a list of icons that are a good enough:

@SmartFinn SmartFinn merged commit 169b6a8 into PapirusDevelopmentTeam:master Aug 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants