Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade truffle #51

Open
2 tasks
jellegerbrandy opened this issue May 24, 2018 · 8 comments · May be fixed by #55
Open
2 tasks

upgrade truffle #51

jellegerbrandy opened this issue May 24, 2018 · 8 comments · May be fixed by #55

Comments

@jellegerbrandy
Copy link
Contributor

We are using truffle 4.1.6

upgradeing to 4.1.7 (which also upgrades solc to 0.4.23) breaks tests in paratii-js

Todo:

  • reproduce the error from apratii-js in a test in paratii-contracts
  • fix and upgrade :-)

https://github.com/trufflesuite/truffle/releases
https://github.com/ethereum/solidity/blob/develop/Changelog.md

@luisfidelis
Copy link

Hi Jelle. If no one is working on it, i would like to start.

@jellegerbrandy
Copy link
Contributor Author

You are very welcome!

@luisfidelis luisfidelis linked a pull request Jun 1, 2018 that will close this issue
@jellegerbrandy
Copy link
Contributor Author

to reproduce these errors in paratii-js, the road to take is to install paratii-js according to the instructions there, upgrade the reference to paratii-contracts in package.json, run a yarn install, and then run the tests.

@luisfidelis
Copy link

Yesterday i've followed these steps, but without change the reference of paratii-contracts i got some errors such as IPFS timeouts and failure when deploying contracts. It might be a trouble in my environment, i'll take a look.

@jellegerbrandy
Copy link
Contributor Author

jellegerbrandy commented Jun 1, 2018 via email

@luisfidelis
Copy link

Yes, for sure. I'll try to run paratii-js tests again and investigate the problem.

@luisfidelis
Copy link

@jellegerbrandy I've noticed two problems when running paratii-js tests:

  1. I couldn't use parity 1.11.1. After downgrading to 1.9.0 a lot of errors has disappeared.
  2. ParatiiIPFSLocal tests doesn't work well
    2.1) it('should allow for file upload', ... ) expects a different multihash of the file stored.
    2.2) it('should add a directory to IPFS',...) getting Timeout error.

@luisfidelis
Copy link

luisfidelis commented Jun 5, 2018

@jellegerbrandy To fix the tests of paratii-js regarding Solidity 0.4.23/24, i had to add these parameters in the section params of chain.json:

   "eip140Transition": 0,
   "eip211Transition": 0,
   "eip214Transition": 0,
   "eip658Transition": 0

It enables byzantium features.
Parity: 1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants