Maze Goal Generator #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khozzy
reviewed
Dec 17, 2018
gym_maze/maze.py
Outdated
| PATH_MAPPING = 0 | ||
| WALL_MAPPING = 1 | ||
| REWARD_MAPPING = 9 | ||
|
|
||
| STATE_ONE_STEP = 0 |
There was a problem hiding this comment.
They describe states of the goal generator. They are not really used right now, mostly for debugging or future use.
| @@ -174,3 +183,27 @@ def get_possible_neighbour_cords(pos_x, pos_y) -> tuple: | |||
| nw = (pos_x - 1, pos_y - 1) | |||
|
|
|||
| return n, ne, e, se, s, sw, w, nw | |||
|
|
|||
| def get_goal_state(self, current_x, current_y): | |||
There was a problem hiding this comment.
What is this function returning? I assume some goal perception? How to interpret this?
There was a problem hiding this comment.
It returns perception of the next goal state. It is used in Action Planning phase.
|
Please get rid of non-used code (it should only contain one that is necessary to run). Also, there are no tests of that functionality. |
khozzy
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added goal generator for Maze environment