Finish hiding loading screen even if tab is hidden #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an unfortunate side effect of the nice fade in/out CSS animations PleaseWait uses. These animations are delayed until the tab regains focus, which makes it *look* like the site hasn't finished loading until the tab is visible (even if `finish()` was called minutes ago). This fix has two parts: 1) Use visibility API to skip the fade out animation if the tab is hidden when finish() is called 2) Use event.stopPropagation() and a finishing flag instead of setTimeout to handle the conflicting event listeners
jhdavids8
added a commit
that referenced
this pull request
Apr 8, 2015
Finish hiding loading screen even if tab is hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfortunate side effect of the nice fade in/out CSS animations PleaseWait uses. These animations are delayed until the tab regains focus, which makes it look like the site hasn't finished loading until the tab is visible (even if
finish()was called minutes ago). This fix has two parts: