Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isingxy latex definition #2858

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Update isingxy latex definition #2858

merged 7 commits into from
Jul 29, 2022

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Jul 22, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2858 (c619638) into master (1f1418d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2858   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         252      252           
  Lines       21004    21004           
=======================================
  Hits        20928    20928           
  Misses         76       76           
Impacted Files Coverage Δ
pennylane/ops/qubit/parametric_ops.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1418d...c619638. Read the comment docs.

doc/releases/changelog-dev.md Show resolved Hide resolved
@mlxd mlxd requested a review from rmoyard July 22, 2022 20:27
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
Copy link
Contributor

@rmoyard rmoyard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 💯

@multiphaseCFD
Copy link
Member Author

It looks good to me 💯

Thanks @rmoyard !

@multiphaseCFD multiphaseCFD merged commit c289d0d into master Jul 29, 2022
@multiphaseCFD multiphaseCFD deleted the fix_latex_def_isingxy branch July 29, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants