[Return-types #4] Parameter shift grad transform #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yLaneAI/pennylane into refactor_return_shot_vector
… into return_types
AlbertMitjans
approved these changes
Sep 9, 2022
…ennylane into grad_transforms_new_return
eddddddy
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Looks good @antalszava 🔥 🔥 🔥
My major comments have all been addressed. I just have 2 more minor requests to clean up the code a bit. Also briefly looked over the tests and they all seem good too 🙂 .
timmysilv
reviewed
Sep 9, 2022
rmoyard
reviewed
Sep 9, 2022
There was a problem hiding this comment.
Great work @antalszava 💯 I've left some about tests that need to be commented. It would also be great to remove the changes for the execution pipeline. Still an open question about creating new gradients function to keep cleaner or do we consider them user facing and then those changes are all good?
…rray conversion as it may create a ragged array
rmoyard
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Thanks @antalszava, I suggest to make the var function private otherwise it looks very good! 💯
antalszava
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This is a continuation of the new return types push that was started in #2814 #2815 #2860.
Description of the Change:
Updates the parameter-shift gradient transform to handle the new way of returning measurement results.
Benefits:
The parameter-shift gradient transform outputs sequences.
Note: most of this PR includes porting over the
tests/gradients/test_parameter_shift.pyfile to be compatible with the new return types structure. Most of the tests are copied from that file and adjusted.Possible Drawbacks:
N/A
Related GitHub Issues:
N/A
TODOs: