Add __mul__ dunder method #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2891 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 258 258
Lines 21759 21772 +13
=======================================
+ Hits 21683 21696 +13
Misses 76 76
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AlbertMitjans
added
review-ready 👌
albi3ro
reviewed
Aug 4, 2022
Co-authored-by: Christina Lee <christina@xanadu.ai>
…nnylane into mul_dunder_method
Jaybsoni
reviewed
Aug 4, 2022
There was a problem hiding this comment.
Looks good to me! Just a few small comments! Also, I think there are some errors that get raised in the Hamiltonian class because we don't currently support multiplication of Hamiltonians. Maybe in the error message there we can direct users to the Prod class.
Just some small changes and then happy to approve 👍🏼
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Jaybsoni
reviewed
Aug 4, 2022
albi3ro
reviewed
Aug 4, 2022
albi3ro
reviewed
Aug 4, 2022
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
albi3ro
reviewed
Aug 5, 2022
Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__mul__and__matmul__dunder methods to theOperatorclass.