Skip to content

Commit

Permalink
Address RT#85406
Browse files Browse the repository at this point in the history
Specifying 'meta-spec' in META_ADD or META_MERGE would remove all
given prereqs.
  • Loading branch information
bingos committed Jun 10, 2013
1 parent 743291a commit 35ad81b
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
5 changes: 5 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
6.67_04
Bug fixes
* Address RT#85406, where specifying 'meta-spec' in
META_[ADD|MERGE] would remove all prereqs (bingos)

6.67_03 Wed Jun 5 22:03:28 BST 2013
Doc Fixes
* Document how to specify meta-spec in META_MERGE (bingos)
Expand Down
19 changes: 18 additions & 1 deletion lib/ExtUtils/MM_Any.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,13 @@ sub metafile_data {
};
}

%meta = $self->_add_requirements_to_meta_v1_4( %meta );
{
my $vers = _metaspec_version( $meta_add, $meta_merge );
my $method = $vers =~ m!^2!
? '_add_requirements_to_meta_v2'
: '_add_requirements_to_meta_v1_4';
%meta = $self->$method( %meta );
}

while( my($key, $val) = each %$meta_add ) {
$meta{$key} = $val;
Expand All @@ -1023,6 +1029,17 @@ sub metafile_data {
=cut

sub _metaspec_version {
my ( $meta_add, $meta_merge ) = @_;
return $meta_add->{'meta-spec'}->{version}
if defined $meta_add->{'meta-spec'}
and defined $meta_add->{'meta-spec'}->{version};
return $meta_merge->{'meta-spec'}->{version}
if defined $meta_merge->{'meta-spec'}
and defined $meta_merge->{'meta-spec'}->{version};
return '1.4';
}

sub _add_requirements_to_meta_v1_4 {
my ( $self, %meta ) = @_;

Expand Down

0 comments on commit 35ad81b

Please sign in to comment.