Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dwellir endpoint for Phala bootnode. #283

Merged
merged 2 commits into from
May 12, 2023

Conversation

Maharacha
Copy link
Contributor

Tested with:
./phala --chain phala --reserved-only --reserved-nodes "/dns4/phala-boot.dwellir.com/tcp/30340/p2p/12D3KooWSHMRKmSQXsu1cbLLPQ3qUqPQijwxXfk1PWVTpU49bKSb"

@Maharacha
Copy link
Contributor Author

We also have wss set up
/dns4/phala-boot.dwellir.com/tcp/443/ws/p2p/12D3KooWSHMRKmSQXsu1cbLLPQ3qUqPQijwxXfk1PWVTpU49bKSb
But it seems like it is not supported yet due to old Polkadot version. Do you want us to add it anyway or wait with it?

@jasl
Copy link
Contributor

jasl commented May 12, 2023

We also have wss set up /dns4/phala-boot.dwellir.com/tcp/443/ws/p2p/12D3KooWSHMRKmSQXsu1cbLLPQ3qUqPQijwxXfk1PWVTpU49bKSb But it seems like it is not supported yet due to old Polkadot version. Do you want us to add it anyway or wait with it?

Thank you, is this break old khala-node ? if no issue with old versions, we can add this into boot nodes now, I'm upgrading the node to polkadot v0.9.42 which fixed many sync issues

@Maharacha
Copy link
Contributor Author

We also have wss set up /dns4/phala-boot.dwellir.com/tcp/443/ws/p2p/12D3KooWSHMRKmSQXsu1cbLLPQ3qUqPQijwxXfk1PWVTpU49bKSb But it seems like it is not supported yet due to old Polkadot version. Do you want us to add it anyway or wait with it?

Thank you, is this break old khala-node ? if no issue with old versions, we can add this into boot nodes now, I'm upgrading the node to polkadot v0.9.42 which fixed many sync issues

The wss endpoint will just give a warning in the log, that it can't connect to it. I'll add it then for the future release. In the end I think you want to remove the non-TLS endpoints and only have bootnodes with TLS. It was fixed in substrate with paritytech/substrate#13152

@jasl jasl merged commit 5f048c7 into Phala-Network:main May 12, 2023
@jasl
Copy link
Contributor

jasl commented May 12, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants