Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selfie feature #874

Open
wants to merge 19 commits into
base: selfie
Choose a base branch
from
Open

Update selfie feature #874

wants to merge 19 commits into from

Conversation

huebim
Copy link

@huebim huebim commented Sep 24, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "x" next to an item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

New Button "Take a Picture" Style
Preview Picture
Warn Message MaxFileSize only less 5MB

Is there anything you'd like reviewers to focus on?

Next TODO:
Warn Message if image bigger then MaxFileSize
"selfie" integration in admin config
button in gallery to "selfie" if it is allowed in the admin panel
gallery portrait format padding left and right 20%
gallery and slideshow on localhost running system have to refresh on db changes

New Button "Take a Picture" Style
Preview Picture 
Warn Message MaxFileSize only less 5MB
Warning if image size to big,
Code cleanup
@andi34
Copy link
Contributor

andi34 commented Sep 24, 2024

https://github.com/PhotoboothProject/photobooth/blob/dev/gallery/index.php#L30

Standalone gallery has the feature already to check for DB changes and reload if is.

@andi34
Copy link
Contributor

andi34 commented Sep 24, 2024

Standalone slideshow checks always like defined for gallery and reloads if needed

https://github.com/PhotoboothProject/photobooth/blob/dev/assets/js/slideshow.js#L184

@huebim
Copy link
Author

huebim commented Sep 25, 2024

New Design in Selfie index.php (upload button only visible when picture in memory and filesize in php posible), removed slidshow button (there is no way to go back)
add selfie button on gallery index.php and hidden on overlay mode, (perfekt QR-Link for all guests)
remove reload button on overlay gallery
TODO:
admin panel ON/OFF Selfie Feature
overlay Gallery refresh db

@huebim huebim changed the title Update index.php Update selfie feature Sep 25, 2024
@huebim
Copy link
Author

huebim commented Sep 27, 2024

I NEED HELP.
I want to integrate the selfie feature into the admin panel with a checkbox on/off and the result should be available in the $config[selfie][enabled] to be used in php. I hope someone can help me with the integration, I'm just destroying the project trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants