First steps towards cross-platform #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's remove the self-written implementation of atomic, because it is used in only one place and generates code no better than the standard implementation
On x86-64, the most significant bits of the RDX:RAX registers are guaranteed to be zero. This means that the rdtsc instruction will return two 64-bit numbers. In practice, this removes the extra instruction to clear the most significant bits of the return value.
Taking one step towards cross-platform
|
Hi Roman-Koshelev, This is a great pull request! Let me verify that everything compiles with my toolchain and that there are no performance regressions. If all goes well, I'll merge the changes to master! 🙂 Best Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.