Addressed latest review comments

PointCloudLibrary · Jan 12, 2023 · 5107383 · 5107383
1 parent 06f029b
commit 5107383
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/common/src/PCLPointCloud2.cpp b/common/src/PCLPointCloud2.cpp
@@ -62,7 +62,7 @@ pcl::PCLPointCloud2::concatenate (pcl::PCLPointCloud2 &cloud1, const pcl::PCLPoi
     cloud1 = cloud2;
   }
 
-  if (size2 == 0) {
+  if ((size1 == 0) || (size2 == 0)) {
     cloud1.header.stamp = std::max (cloud1.header.stamp, cloud2.header.stamp);
     return true;
   }

diff --git a/registration/src/correspondence_rejection_trimmed.cpp b/registration/src/correspondence_rejection_trimmed.cpp
@@ -47,8 +47,8 @@ pcl::registration::CorrespondenceRejectorTrimmed::getRemainingCorrespondences(
 {
   // not really an efficient implementation
   remaining_correspondences = original_correspondences;
-  unsigned int number_valid_correspondences = (static_cast<int>(std::floor(
-      overlap_ratio_ * static_cast<float>(remaining_correspondences.size()))));
+  auto number_valid_correspondences = static_cast<unsigned int>(std::floor(
+      overlap_ratio_ * static_cast<float>(remaining_correspondences.size())));
   number_valid_correspondences =
       std::max(number_valid_correspondences, nr_min_correspondences_);