Added modernize-use-auto to clang-tidy-checks

[gnawme]

When clang-tidy checks were added to the Github workflow in #4636, modernize-use-auto was omitted.

Using auto can greatly enhance the readability and usability of the code.

[mvieth]

Personally, I would e.g. prefer float and double over auto, because they are still very short but more expressive. How about increasing MinTypeNameLength (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-auto.html#cmdoption-arg-mintypenamelength) to 7? And maybe some of the for-loops with iterators can be converted to range-for-loops?

[gnawme]

Personally, I would e.g. prefer float and double over auto, because they are still very short but more expressive. How about increasing MinTypeNameLength (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-auto.html#cmdoption-arg-mintypenamelength) to 7? And maybe some of the for-loops with iterators can be converted to range-for-loops?

Thanks, yes, I think I'll follow both suggestions. Here is Part I, with MinTypeNameLength set

[mvieth]

This pull request has gotten very big, far too big for a proper (and fast) review. Can you split it? Maybe move all commits after Fixed merge error (the first commit where all CI checks passed) to one or more additional pull requests? Thanks!

[gnawme]

This pull request has gotten very big, far too big for a proper (and fast) review. Can you split it? Maybe move all commits after Fixed merge error (the first commit where all CI checks passed) to one or more additional pull requests? Thanks!

Done, it's still quite a large PR, but I don't see a sensible way to split it further.

[mvieth]

Thanks for splitting the PR

[mvieth]

Thanks!