Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review casts in PCL, Part B #5508

Merged
merged 12 commits into from
Jan 17, 2023
Merged

Review casts in PCL, Part B #5508

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
de9781d
Initial application of google-readability-casting
gnawme Nov 8, 2022
346b72b
Addressed google-readability-casting escapes
gnawme Nov 8, 2022
e7d62f4
Addressed clang-format violations flagged by CI
gnawme Nov 8, 2022
8d94b0b
More clang-format escapes
gnawme Nov 8, 2022
e6cb961
Addressed clang-tidy escapes
gnawme Nov 9, 2022
e3996f6
Fixed compile issue not seen on desktop
gnawme Nov 9, 2022
59fd213
Addressed review comments
gnawme Nov 14, 2022
79fe03e
Fixed clang-tidy complaint
gnawme Nov 14, 2022
f257e3b
Clarified PCLPointCloud2::concatenate logic
gnawme Nov 16, 2022
06f029b
Addressed latest review comments
gnawme Dec 24, 2022
5107383
Addressed latest review comments
gnawme Jan 4, 2023
258e1a1
Eliminated double casts per review
gnawme Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Eliminated double casts per review
  • Loading branch information
@gnawme
gnawme committed Jan 16, 2023
commit 258e1a109eba612837390d9e36415230be31a3ab
4 changes: 2 additions & 2 deletions geometry/include/pcl/geometry/mesh_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class MeshBase {
{
vertices_.push_back(Vertex());
this->addData(vertex_data_cloud_, vertex_data, HasVertexData());
return (static_cast<VertexIndex>(static_cast<int>(this->sizeVertices() - 1)));
return (static_cast<VertexIndex>(this->sizeVertices() - 1));
}

/**
Expand Down Expand Up @@ -1251,7 +1251,7 @@ class MeshBase {
this->addData(half_edge_data_cloud_, he_data, HasHalfEdgeData());
this->addData(edge_data_cloud_, edge_data, HasEdgeData());

return (static_cast<HalfEdgeIndex>(static_cast<int>(half_edges_.size() - 2)));
return (static_cast<HalfEdgeIndex>(half_edges_.size() - 2));
}

////////////////////////////////////////////////////////////////////////
Expand Down