Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sample_consensus] Adds Ellipse3D SacModel Class #5512

Merged
merged 4 commits into from
Nov 16, 2022
Merged

[sample_consensus] Adds Ellipse3D SacModel Class #5512

merged 4 commits into from
Nov 16, 2022

Conversation

mnobrecastro
Copy link
Contributor

Follows issue #5431 (Cont. of PR #5430).

@mnobrecastro
Copy link
Contributor Author

Dear @mvieth here is a new PR using the second approach you suggested. I think that this solves the problem. Thank you for all support during the review of this PR.

@mvieth mvieth added changelog: new feature Meta-information for changelog generation module: sample_consensus labels Nov 12, 2022
mvieth
mvieth previously approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you again for your contribution!
@larshg Do you want to take a look before I merge?

@mnobrecastro
Copy link
Contributor Author

Dear @larshg, I think I managed to accommodate all your comments. Could you please double check? Thank you.

@larshg
Copy link
Contributor

larshg commented Nov 14, 2022

Hey @mnobrecastro

I have pin pointed some more variables that could be const.

There are quite a few more (also in the other methods) and hopefully its worth changing, to avoid errors, get performance improvements etc.

@mnobrecastro
Copy link
Contributor Author

Hey @mnobrecastro

I have pin pointed some more variables that could be const.

There are quite a few more (also in the other methods) and hopefully its worth changing, to avoid errors, get performance improvements etc.

I believe that all possible const vars were amended, but please confirm. And @mvieth @larshg , thank you both for restarting the failed builds.

@mvieth mvieth merged commit ee3dca2 into PointCloudLibrary:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshg larshg larshg approved these changes

@mvieth mvieth mvieth approved these changes

Assignees
No one assigned
Labels
changelog: new feature Meta-information for changelog generation module: sample_consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnobrecastro @larshg @mvieth