Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #5523

Merged
merged 5 commits into from
Dec 10, 2022
Merged

Fix various typos #5523

merged 5 commits into from
Dec 10, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 21, 2022

Found via codespell -q 3 -S ./CHANGES.md,./surface/src/3rdparty,./surface/include/pcl/surface/3rdparty,./recognition/include/pcl/recognition/3rdparty -L ang,bu,childs,coo,currect,frome,gool,hsi,indeces,ihs,indext,ith,lod,meshe,metre,metres,nd,opps,ot,te,vertexes

Found via `codespell -q 3 -S ./CHANGES.md,./surface/src/3rdparty,./surface/include/pcl/surface/3rdparty,./recognition/include/pcl/recognition/3rdparty -L ang,bu,childs,coo,currect,frome,gool,hsi,indeces,ihs,indext,ith,lod,meshe,metre,metres,nd,opps,ot,te,vertexes`
@luzpaz luzpaz changed the title Typos (under constructions Fix various typos Nov 21, 2022
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow these recommendations to make the formatting CI pass

cuda/common/include/pcl/cuda/cutil.h Outdated Show resolved Hide resolved
filters/src/extract_indices.cpp Outdated Show resolved Hide resolved
@@ -111,15 +111,15 @@ namespace pcl
// CloudPtrT
// getCloudPtr () const;

/** \brief Paint View function - reimpliment in item subclass if it can be displayed in PCLVisualizer*/
/** \brief Paint View function - reimpiement in item subclass if it can be displayed in PCLVisualizer*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right (more instances)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b5e1531

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 27, 2022

Thx, will do so this week

luzpaz and others added 3 commits November 28, 2022 15:21
Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>
Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>
@mvieth
Copy link
Member

mvieth commented Nov 30, 2022

Please make these changes to make the formatting CI pass:

--- a/ml/src/svm_wrapper.cpp
+++ b/ml/src/svm_wrapper.cpp
@@ -667,9 +667,10 @@ pcl::SVMClassify::classification()
 
   if (predict_probability_) {
     if (svm_check_probability_model(&model_) == 0) {
-      PCL_WARN("[pcl::%s::classification] Classifier model does not support probability "
-               "estimates. Automatically disabled.\n",
-               getClassName().c_str());
+      PCL_WARN(
+          "[pcl::%s::classification] Classifier model does not support probability "
+          "estimates. Automatically disabled.\n",
+          getClassName().c_str());
       predict_probability_ = false;
     }
   }
@@ -748,9 +749,10 @@ pcl::SVMClassify::classification(pcl::SVMData in)
 
   if (predict_probability_) {
     if (svm_check_probability_model(&model_) == 0) {
-      PCL_WARN("[pcl::%s::classification] Classifier model does not support probability "
-               "estimates. Automatically disabled.\n",
-               getClassName().c_str());
+      PCL_WARN(
+          "[pcl::%s::classification] Classifier model does not support probability "
+          "estimates. Automatically disabled.\n",
+          getClassName().c_str());
       predict_probability_ = false;
     }
   }

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 30, 2022

@mvieth how to do I apply the patch via the CLI ?
when I run:
xclip -selection clipboard -o | git apply
Result:
error: corrupt patch at line 30

Edit: nm, i've added the changed manually in c53c838

Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
(failing docker is unrelated and will be fixed by another pull request)

@mvieth mvieth added the changelog: fix Meta-information for changelog generation label Dec 3, 2022
@mvieth mvieth added this to the pcl-1.13.1 milestone Dec 3, 2022
@mvieth mvieth merged commit 44670ff into PointCloudLibrary:master Dec 10, 2022
@luzpaz luzpaz deleted the typos branch December 11, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants