Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated code for 1.14 release #5872

Merged

Conversation

KStew8111
Copy link
Contributor

The deprecated methods have been removed from the listed files. Please let me know if there are any issues!

@mvieth
Copy link
Member

mvieth commented Nov 12, 2023

Hi, thanks for this pull request. Please also remove the corresponding function definitions (not just the function declarations) from segmentation/include/pcl/segmentation/impl/extract_labeled_clusters.hpp and gpu/octree/src/octree.cpp. And please make sure that the checks all pass (if not, you can click on them to find out what is wrong).

@mvieth mvieth added the changelog: removal Meta-information for changelog generation label Nov 12, 2023
@mvieth mvieth added this to the pcl-1.14.0 milestone Nov 12, 2023
@mvieth mvieth linked an issue Nov 12, 2023 that may be closed by this pull request
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvieth mvieth merged commit b4c9758 into PointCloudLibrary:master Nov 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: removal Meta-information for changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated code before the 1.14 release
3 participants