Make UniformSampling inherit from FilterIndices instead of Filter #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
reviewed
Jun 12, 2024
| } | ||
| } | ||
|
|
||
| // Second pass: go over all leaves and copy data | ||
| output.resize (leaves_.size ()); | ||
| std::size_t cp = 0; |
There was a problem hiding this comment.
Suggested change
| std::size_t cp = 0; |
There was a problem hiding this comment.
I think this one is not used.
larshg
reviewed
Jun 12, 2024
mvieth
reviewed
Jun 12, 2024
mvieth
reviewed
Jun 13, 2024
mvieth
added
changelog: enhancement
larshg
reviewed
Jun 14, 2024
| if (!std::isfinite ((*input_)[(*indices_)[cp]].x) || | ||
| !std::isfinite ((*input_)[(*indices_)[cp]].y) || | ||
| !std::isfinite ((*input_)[(*indices_)[cp]].z)) | ||
| if (!std::isfinite ((*input_)[cp].x) || |
There was a problem hiding this comment.
Could use pcl::isXYZFinite.
larshg
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finish #6051
Please let me know if there is anything that needs to be modified