Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Fix migration test #360

Merged
merged 1 commit into from
Jul 21, 2024
Merged

🔧 Fix migration test #360

merged 1 commit into from
Jul 21, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Jul 19, 2024

What?

  • Fix our pallet migration integration test

Why?

  • We added a real benchmarked weight to the confirm_pallet_migrations extrinsic, but forgot to reflect that change when setting the max weight for the ReportTransactStatus message appended at the end of a migration.

How?

The xcm logs showed that the message was overweight:

 events::Polimec: RuntimeEvent::PolkadotXcm(Event::NotifyOverweight { query_id: 2, pallet_index: 80, call_index: 30, actual_weight: Weight { ref_time: 573050100, proof_size: 33831 }, max_budgeted_weight: Weight { ref_time: 700000000, proof_size: 10000 } })    

As you can see the actual weight was:

  • Weight { ref_time: 573050100, proof_size: 33831 }

And the max weight we set was

  • Weight { ref_time: 700000000, proof_size: 10000 }

Therefore we now increase the max weight to 1_000_000_000 and 50_000

Testing?

run full_pallet_migration_test

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios changed the title Fix migration test 🔧 Fix migration test Jul 19, 2024
@JuaniRios JuaniRios self-assigned this Jul 19, 2024
@JuaniRios JuaniRios marked this pull request as ready for review July 19, 2024 14:34
@lrazovic lrazovic merged commit a899c98 into main Jul 21, 2024
@lrazovic lrazovic deleted the 07-19-fix_migration_test branch July 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants