Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👨🏻‍💻 Tightly couple linear-release to funding pallet #391

Merged
merged 1 commit into from
Sep 12, 2024
Merged

👨🏻‍💻 Tightly couple linear-release to funding pallet #391

merged 1 commit into from
Sep 12, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 3, 2024 •
edited
Loading

What?

  • Title

Why?

  • Solving the schedule merging problem requires some functions not exposed through the trait, and we anyway don't care about making the funding pallet reusable. So easier to tightly couple our vesting pallet

How?

  • Remove duplicated config types
  • Remove Vesting config type
  • Add linear release Config to funding config required traits

@JuaniRios JuaniRios mentioned this pull request Sep 3, 2024
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Sep 3, 2024
Closed
@JuaniRios JuaniRios changed the title Linear release merging schedules 👨🏻‍💻 Tightly couple linear-release to funding pallet Sep 3, 2024
This was referenced Sep 3, 2024
Merged
Merged
Merged
Merged
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 698bf3c to 7e35b82 Compare September 3, 2024 13:20
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 7e35b82 to ced692f Compare September 3, 2024 14:06
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from ced692f to e243ba0 Compare September 3, 2024 14:19
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from e243ba0 to 70d869b Compare September 3, 2024 14:29
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 70d869b to 54a468b Compare September 3, 2024 14:37
@JuaniRios JuaniRios marked this pull request as ready for review September 4, 2024 10:45
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 4, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (09/04/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 54a468b to fb4ff1a Compare September 4, 2024 13:07
@JuaniRios JuaniRios mentioned this pull request Sep 4, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from fb4ff1a to 2229b2d Compare September 9, 2024 11:10
@JuaniRios JuaniRios changed the base branch from 09-03-cargo_clippy_fmt to 09-03-hide_instantiator_behind_feature_flag September 9, 2024 11:10
@JuaniRios JuaniRios mentioned this pull request Sep 9, 2024
Merged
@JuaniRios JuaniRios changed the base branch from 09-03-hide_instantiator_behind_feature_flag to graphite-base/391 September 10, 2024 08:38
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from 2229b2d to a3347fa Compare September 10, 2024 08:40
@JuaniRios JuaniRios changed the base branch from graphite-base/391 to main September 10, 2024 08:41
@JuaniRios JuaniRios force-pushed the 09-03-linear_release_merging_schedules branch from a3347fa to 8448527 Compare September 10, 2024 08:41
vstam1
vstam1 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@vstam1 vstam1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 12, 2024 •
edited
Loading

Merge activity

@JuaniRios JuaniRios merged commit b61c009 into main Sep 12, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-03-linear_release_merging_schedules branch September 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 vstam1 approved these changes

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuaniRios @lrazovic @vstam1