Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weighted voting module #578

Merged
merged 23 commits into from
Apr 10, 2019
Merged

Add weighted voting module #578

merged 23 commits into from
Apr 10, 2019

Conversation

satyamakgec
Copy link
Contributor

No description provided.

@satyamakgec satyamakgec mentioned this pull request Mar 4, 2019
3 tasks
@satyamakgec satyamakgec changed the title add weighted voting module [WIP]: Add weighted voting module Mar 4, 2019
@coveralls
Copy link

coveralls commented Mar 4, 2019

Coverage Status

Coverage remained the same at 95.134% when pulling 04fbdcc on weighted-voting-module into 47624d8 on dev-3.0.0.

@satyamakgec satyamakgec changed the title [WIP]: Add weighted voting module Add weighted voting module Mar 6, 2019
@satyamakgec
Copy link
Contributor Author

Everything is fixed only one thing remains i.e proposalId starts from 0. I keep that as it is because if I start with it 0 then there is no way to restrict the user to vote again until unless I will use another storage variable to keep track of it. IMO it is best over introducing another variable to do it.

@satyamakgec satyamakgec merged commit 5d87221 into dev-3.0.0 Apr 10, 2019
@maxsam4 maxsam4 deleted the weighted-voting-module branch April 10, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants