Fixes distribution of item template via named slots (Fixes 479) #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2017 14:56
When stamping the item template (when creating a pool), make the stamped instance inherit its template slot attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #479 by having each stamped instance of an item template inherit the slot attribute on the template item. In the
_createPoolfunction, the template is stamped and each new instance is appended as children to the template's parent node. When the template reaches theiron-listelement via named slots, this will result in an incorrect distribution of the new nodes, becauseiron-listwill not be able to correctly identify its assigned nodes.See #479 for reasoning behind this approach over modifying the behavior of
Polymer.Templatizerand a work around until this lands.The accompanying tests use two levels of
sloting to demonstrate this.