Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss485 - backend database #501

Merged
merged 14 commits into from
Jan 23, 2024
Merged

Iss485 - backend database #501

merged 14 commits into from
Jan 23, 2024

Conversation

SandeepThokala
Copy link
Collaborator

No description provided.

batch.py Outdated Show resolved Hide resolved
@GopiGugan
Copy link
Contributor

GopiGugan commented Dec 21, 2023

  • Lets also add psycopg2 as a dependency in INSTALL.md
  • Add instructions on how to setup database locally

@ArtPoon ArtPoon mentioned this pull request Jan 9, 2024
Merged
@ArtPoon ArtPoon changed the title Iss485 Iss485 - backend database Jan 16, 2024
@GopiGugan
Copy link
Contributor

Adding step to create database "gsaid_db" if it doesn't exist

@GopiGugan
Copy link
Contributor

Should there be an option to run the pipeline without using the database?

@ArtPoon
Copy link
Contributor

ArtPoon commented Jan 23, 2024

Should there be an option to run the pipeline without using the database?

Yes I prefer to keep old functionality around in case of an unanticipated use case, or we have to roll things back. Specifying some --option with action="store_true" would do the job.

@ArtPoon ArtPoon merged commit 661ce10 into dev Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants