Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed -NoNewLine parameter from Set-Content #16

Merged
merged 2 commits into from
May 1, 2018

Conversation

lipkau
Copy link
Contributor

@lipkau lipkau commented Jan 31, 2018

Set-Content only supports the -NoNewLine parameter starting with Windows Powershell 5
closes #15

not sure if you want the PR to increment the psd1 version

`Set-Content` only supports the `-NoNewLine` parameter starting with Windows Powershell 5
closes PoshCode#15
@lipkau
Copy link
Contributor Author

lipkau commented May 1, 2018

I tested the command with

1..20| % {Update-Metadata -Path $path -PropertyName Author -Value $_}

And the .psd1 file had exactly the same amout of new lines at the end.

Copy link
Member

@Jaykul Jaykul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support older PowerShell versions, and the extra empty line isn't hurting anyone.

@Jaykul Jaykul merged commit 4b81b22 into PoshCode:dev May 1, 2018
@lipkau lipkau deleted the fix/unknownParameter branch July 11, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants