Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation around CustomRulePath in Settings file to README.md #1636

Merged

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Feb 2, 2021

PR Summary

  • Add documentation around CustomRulePath in Settings file to README.md

PR Checklist


This change is Reviewable

@johlju
Copy link
Contributor Author

johlju commented Feb 2, 2021

@bergmeister as per request the updated docs.

@johlju johlju force-pushed the fix/readme-multiple-customrulepaths branch from e53fc60 to 93dbaed Compare February 2, 2021 12:27
@johlju
Copy link
Contributor Author

johlju commented Feb 2, 2021

Not sure why the build is failing. Looks like pipeline is broken?

@bergmeister
Copy link
Collaborator

Not sure why the build is failing. Looks like pipeline is broken?

It's a sporadic failure, for which I have PR #1632 to fix. I restarted the build, which worked this time.

Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write down your findings. Just one small suggestion please.

README.md Show resolved Hide resolved
@bergmeister bergmeister merged commit 820cde9 into PowerShell:master Feb 7, 2021
@johlju johlju deleted the fix/readme-multiple-customrulepaths branch February 7, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants