Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SA1517: Code should not contain blank lines at start of file #14131

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

xtqqczze
Copy link
Contributor

@ghost ghost assigned daxian-dbw Nov 18, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 18, 2020 20:24
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 19, 2020
@ghost ghost removed this from the 7.2.0-preview.2 milestone Nov 19, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2020
@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Nov 20, 2020
@iSazonov iSazonov merged commit fa657ef into PowerShell:master Nov 20, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 20, 2020
@xtqqczze xtqqczze deleted the SA1517 branch November 20, 2020 13:27
@ghost
Copy link

ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants