#4750 Fix Get-Date -UFormat %u behavior

[brianary]

PR Summary

Corrects the behavior of %u in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed: Document Request: Get-Date -UFormat %u ISO8601 standard (1-7) MicrosoftDocs/PowerShell-Docs#7180
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ghost]

All CLA requirements met.

[brianary]

I can't really access the details, but the test failures appear to be unrelated.

[iSazonov]

Please clarify how you select the test values (whole list)?

[brianary]

I just used the values from the previous test for %V, which is related, then added a couple recent dates that had led to discovering the bug. I'll add a comment to that effect, or else select some other dates.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[brianary]

Let me know if there's anything further I can provide.

[iSazonov]

@brianary Since it is a breaking change I ask PowerShell Committee to approve.

[SteveL-MSFT]

@PowerShell/powershell-committee reviewed this, we agreed that this is a bug that should be fixed and this is likely a bucket 3 compatibility issue.

[brianary]

@SteveL-MSFT should #14555 also be taken with this one, since they are so tightly related?

[iSazonov]

@brianary Please create new issue in PowerShell-Doc repository and add a reference to the issue in the PR description.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

[iSazonov]

@brianary Please rebase. I hope after that CI-Windows will pass.

[iSazonov]

@brianary Thanks for your contribution!

[ghost]

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes