Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new members to Engine and Cmdlet Working Groups (and typo fix) #15560

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

joeyaiello
Copy link
Contributor

@joeyaiello joeyaiello commented Jun 10, 2021

PR Summary

As discussed by @PowerShell/powershell-committee, we're happy to welcome new community members to our Engine and Cmdlet Working Groups (the latter of which we recently decided to instantiate to manage those modules that live within PowerShell/PowerShell).

We're pleased to bring both @vexx32 and @rkeithhill onboard to the Engine WG, as well as @TobiasPSP and @jdhitsolutions to the Cmdlet WG.

To move forward, we should probably get a final Committee-Approved label (as a formality) /cc @SteveL-MSFT

PR Checklist

@joeyaiello joeyaiello added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Jun 10, 2021
@daxian-dbw
Copy link
Member

/bin/bash --noprofile --norc /home/vsts/work/_temp/55508924-6b9e-4fb5-9ebd-2a4d95d6b426.sh
    docs/community/working-group-definitions.md
      139 | * @TobiasPSP 
      140 | * @jdhitsolutions 

>> 2 spelling errors found in 76 files

@joeyaiello The spelling checks failed in CI. You will have to update the .spelling file. You can run mdspell '**/*.md' '!**/Pester/**/*.md' '!**/perf/**/*.md' --ignore-numbers --ignore-acronyms --en-us and choose "add to ignore file" as a spelling issue is spotted, or you can manually update .spelling.

@daxian-dbw daxian-dbw self-assigned this Jun 14, 2021
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 15, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 15, 2021
@SteveL-MSFT SteveL-MSFT added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Jun 15, 2021
@daxian-dbw daxian-dbw merged commit eeabbe7 into PowerShell:master Jun 15, 2021
@daxian-dbw daxian-dbw added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 15, 2021
@daxian-dbw daxian-dbw added this to the 7.2.0-preview.7 milestone Jun 15, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log Committee-Reviewed PS-Committee has reviewed this and made a decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants