-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new members to Engine and Cmdlet Working Groups (and typo fix) #15560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyaiello
added
the
Review - Committee
The PR/Issue needs a review from the PowerShell Committee
label
Jun 10, 2021
vexx32
approved these changes
Jun 11, 2021
rkeithhill
approved these changes
Jun 11, 2021
@joeyaiello The spelling checks failed in CI. You will have to update the |
rjmholt
reviewed
Jun 14, 2021
SteveL-MSFT
requested changes
Jun 15, 2021
ghost
added
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
Jun 15, 2021
ghost
removed
the
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
label
Jun 15, 2021
SteveL-MSFT
approved these changes
Jun 15, 2021
SteveL-MSFT
added
Committee-Reviewed
PS-Committee has reviewed this and made a decision
and removed
Review - Committee
The PR/Issue needs a review from the PowerShell Committee
labels
Jun 15, 2021
daxian-dbw
added
the
CL-Docs
Indicates that a PR should be marked as a documentation change in the Change Log
label
Jun 15, 2021
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-Docs
Indicates that a PR should be marked as a documentation change in the Change Log
Committee-Reviewed
PS-Committee has reviewed this and made a decision
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As discussed by @PowerShell/powershell-committee, we're happy to welcome new community members to our Engine and Cmdlet Working Groups (the latter of which we recently decided to instantiate to manage those modules that live within PowerShell/PowerShell).
We're pleased to bring both @vexx32 and @rkeithhill onboard to the Engine WG, as well as @TobiasPSP and @jdhitsolutions to the Cmdlet WG.
To move forward, we should probably get a final
Committee-Approved
label (as a formality) /cc @SteveL-MSFTPR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).