Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minor versions from PSCompatibleVersions #18635

Merged
merged 3 commits into from
May 8, 2023

Conversation

xtqqczze
Copy link
Contributor

Supercedes #18346.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 22, 2022
@xtqqczze xtqqczze marked this pull request as draft November 22, 2022 14:56
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests need to be updated

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 22, 2022
@kilasuit

This comment was marked as resolved.

Copy link
Collaborator

@kilasuit kilasuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'd prefer to see

private static readonly Version s_psV6Version = new(6,2);
private static readonly Version s_psV7Version = new(7,2);

@kilasuit

This comment was marked as resolved.

@iSazonov
Copy link
Collaborator

I'd be more willing to see this not remove all minor versions but instead leave the latest minor version

Language breaking change can be introduced only in new major version.

@SteveL-MSFT
Copy link
Member

@kilasuit the @PowerShell/powershell-committee's position is 7.0 represents 7.x (docs will need to be updated) instead of perpetually updating this list with every yearly release of 7.x.

@kilasuit
Copy link
Collaborator

kilasuit commented Nov 22, 2022

@SteveL-MSFT that's fair, just wanted to highlight this possible other viewpoint so that it's mentioned within this PR for full transparency to those coming to this in future as it was not clear prior to my comments

@kilasuit kilasuit self-requested a review November 22, 2022 19:07
Copy link
Collaborator

@kilasuit kilasuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on comments from @SteveL-MSFT

@ghost ghost added the Stale label Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@daxian-dbw daxian-dbw marked this pull request as ready for review December 7, 2022 21:39
@daxian-dbw
Copy link
Member

@xtqqczze There are some tests that need to be updated accordingly.

@ghost ghost removed Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 7, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 20, 2022
@ghost
Copy link

ghost commented Dec 20, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin May 1, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@daxian-dbw
Copy link
Member

@xtqqczze Can you please fix the failing tests? Some tests need to be updated accordingly.

@daxian-dbw daxian-dbw added Needs-Triage The issue is new and needs to be triaged by a work group. and removed Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@pull-request-quantifier-deprecated

This PR has 40 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +23 -17
Percentile : 16%

Total files changed: 2

Change summary by file extension:
.cs : +3 -8
.ps1 : +20 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw
Copy link
Member

Pushed commit to fix the tests.

@daxian-dbw daxian-dbw merged commit 1962335 into PowerShell:master May 8, 2023
39 checks passed
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants