-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove minor versions from PSCompatibleVersions
#18635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some tests need to be updated
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'd prefer to see
private static readonly Version s_psV6Version = new(6,2);
private static readonly Version s_psV7Version = new(7,2);
This comment was marked as resolved.
This comment was marked as resolved.
Language breaking change can be introduced only in new major version. |
@kilasuit the @PowerShell/powershell-committee's position is |
@SteveL-MSFT that's fair, just wanted to highlight this possible other viewpoint so that it's mentioned within this PR for full transparency to those coming to this in future as it was not clear prior to my comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on comments from @SteveL-MSFT
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
@xtqqczze There are some tests that need to be updated accordingly. |
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
@xtqqczze Can you please fix the failing tests? Some tests need to be updated accordingly. |
bf0cc13
to
f31ccf6
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Pushed commit to fix the tests. |
🎉 Handy links: |
Supercedes #18346.