Generate AppImage #2027
Generate AppImage #2027
Conversation
|
Hi @probonopd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@probonopd, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Here is the log of a build in which the AppImage actually gets generated (it does not in PRs, as do the other packages): https://travis-ci.org/probonopd/PowerShell/builds/154322840 |
| @@ -2,14 +2,15 @@ Package installation instructions | |||
| ================================= | |||
|
|
|||
| Supports [Ubuntu 14.04][u14], [Ubuntu 16.04][u16], | |||
| [CentOS 7][cos], and [OS X 10.11][osx]. | |||
| [CentOS 7][cos], [most Linux distributions (AppImage)][lai], and [OS X 10.11][osx]. | |||
There was a problem hiding this comment.
Can we say many instead of most? And add a link to AppImage for more info. #Resolved
|
Can you do an interactive rebase so that there is one change per file (or less?) #WontFix |
|
It doesn't appear to be a problem related to the AppImage. I tested both saving and restoring the location; and not doing the AppImage generation until after the Pester tests. I'm testing a rebase now. |
As it works independently of New-UnixPackage, I don't think it should be run there.
Also put version back to 6.0.0-alpha.9 (- instead of .). Removed $LOWERAPP as it was no longer needed.
The previous failure we saw was because the most recent annotated tag did not exist in the previous 50 commits. In my experience we've gone about ~300 commits between tags, so I believe 1000 to be safe, but know 100 will not be.
Suggested changes for AppImage
|
Continued in #2082, hence closing here. |
* Use icon from local repository #2027 (comment) * Use the deb that has been generated in this build * Copyright and license #2027 (comment) * MIT License for appimage.sh #2027 (comment) * Full text of the MIT License is in license_thirdparty_proprietary.txt * Clarify license and clean up unused code #2027 (comment) * Mark appimage.sh as executable
* Use icon from local repository PowerShell#2027 (comment) * Use the deb that has been generated in this build * Copyright and license PowerShell#2027 (comment) * MIT License for appimage.sh PowerShell#2027 (comment) * Full text of the MIT License is in license_thirdparty_proprietary.txt * Clarify license and clean up unused code PowerShell#2027 (comment) * Mark appimage.sh as executable
Closes #2024
AppImage is a packaging format for Linux that lets users download one single file, set the executable bit and run the application (here: PowerShell). Unlike other solutions, no special runtime infrastructure must be installed on the target system(s).
This pull request, when merged, will package PowerShell as an AppImage and upload it.