Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSH hostname parsing to be case sensitive and refactor remoting methods to static class #20968

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fix SSH hostname parsing to be case sensitive and refactor remoting methods to static class #20968

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e742831
Extracting original host name to preserve case for SSH hostname parsing
ArmaanMcleod Dec 25, 2023
5214ca4
Make variables host instead of hostname and add ternary if host is no…
ArmaanMcleod Dec 25, 2023
a088151
Add condition to check Uri host name type is DNS before doing substri…
ArmaanMcleod Dec 26, 2023
a8e2ce5
Move common remoting util methods to static class
ArmaanMcleod Jan 1, 2024
e82969d
Refactor ResolveComputerName
ArmaanMcleod Jan 1, 2024
b7e8db5
Add xunit remoting tests
ArmaanMcleod Jan 1, 2024
3496611
Fixing codefactor
ArmaanMcleod Jan 1, 2024
65b241f
Fixing capitalization param tag codefactor
ArmaanMcleod Jan 1, 2024
bcc8f68
Wrap terminating error into private method
ArmaanMcleod Jan 1, 2024
b0f8a69
Formatting name type check
ArmaanMcleod Jan 3, 2024
02dc639
Merge branch 'master' into fix-ssh-remoting-hostname-parsing
ArmaanMcleod May 17, 2024
fee4984
Adding upper case characters to host name tests from PR feedback.
ArmaanMcleod May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding upper case characters to host name tests from PR feedback.
  • Loading branch information
@ArmaanMcleod
ArmaanMcleod committed May 17, 2024
commit fee498469ed0f76780ddab09694bba12d6a26a21
12 changes: 6 additions & 6 deletions test/xUnit/csharp/test_RemotingUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,29 +30,29 @@ public void TestParseSshHostname()
[Fact]
public void TestParseSshHostnameWithPort()
{
string hostname = "foo.bar.com:22";
string hostname = "Foo.Bar.com:22";
RemotingUtils.ParseSshHostName(cmdlet, hostname, out string host, out string userName, out int port);
Assert.Equal("foo.bar.com", host);
Assert.Equal("Foo.Bar.com", host);
Assert.Null(userName);
Assert.Equal(22, port);
}

[Fact]
public void TestParseSshHostnameWithUsername()
{
string hostname = "user@foo.bar.com";
string hostname = "user@Foo.Bar.com";
RemotingUtils.ParseSshHostName(cmdlet, hostname, out string host, out string userName, out int port);
Assert.Equal("foo.bar.com", host);
Assert.Equal("Foo.Bar.com", host);
Assert.Equal("user", userName);
Assert.Equal(0, port);
}

[Fact]
public void TestParseSshHostnameWithUsernameAndPort()
{
string hostname = "user@foo.bar.com:22";
string hostname = "user@Foo.Bar.com:22";
RemotingUtils.ParseSshHostName(cmdlet, hostname, out string host, out string userName, out int port);
Assert.Equal("foo.bar.com", host);
Assert.Equal("Foo.Bar.com", host);
Assert.Equal("user", userName);
Assert.Equal(22, port);
}
Expand Down
Loading