Jameswtruher/dailytravis #2696
Merged
Jameswtruher/dailytravis #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cron job needs to be created to start the build, and the variable TRAVIS_DAILY_BUILD must be set to true
…umentation TRAVIS_EVENT_TYPE == "cron"
vors
reviewed
Nov 16, 2016
| @@ -1,7 +1,10 @@ | |||
| set -x | |||
| ulimit -n 4096 | |||
| # do this for our daily build test run | |||
| if [[ "$TRAVIS_EVENT_TYPE" == "cron" ]]; then | |||
| powershell -c "Import-Module ./build.psm1; Start-PSBootstrap; Start-PSBuild -CrossGen; Start-PSPester -Tag @('CI','Feature','Scenario') -ExcludeTag RequireAdminOnWindows; Start-PSxUnit" | |||
There was a problem hiding this comment.
Start-PSBootstrap
Maybe we still want packages out of it? I.e. Start-PSBootstrap -Package; ...; Start-PSPackage
There was a problem hiding this comment.
I was wondering about that, my thought that was if we're not doing it for pull requests, i didn't want to do it here. I'm open to an alternative position, though. @andschwa do you have an opinion?
vors
approved these changes
Nov 16, 2016
vors
reviewed
Nov 16, 2016
| @@ -1,7 +1,10 @@ | |||
| set -x | |||
| ulimit -n 4096 | |||
| # do this for our daily build test run | |||
| if [[ "$TRAVIS_EVENT_TYPE" == "cron" ]]; then | |||
There was a problem hiding this comment.
Maybe we can leave some other hook to allow full builds on CI with REST api.
There was a problem hiding this comment.
yah - that's the plan for the future, but I don't know what that hook will look like. For the moment I wanted to get builds started sooner, rather than later.
JamesWTruher
added
Area-Maintainers-Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like using cron on travis-ci will enable us to create daily builds. However, travis-ci doesn't allow for cron jobs to be run at any particular time. Also, it does not appear that it is possible to label these builds, so they will just appear in the same stream as other builds.
The tests are not marked as throwonfailure for the execution of the pester tests because I want to be sure that we always upload our artifacts.
After this change is merged, we can create the cron job (which is now enabled for us in travis-ci)