-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ConsoleReadLine for debugger input #460
Conversation
@palladia Can't approve, CI checks failed. Can you take a look? |
I see this: E: Failed to fetch http://apt-mo.trafficmanager.net/repos/dotnet/pool/main/d/dotnet-nightly/dotnet-nightly_1.0.1.001111-1_amd64.deb 404 Not Found From: Andy Schwartzmeyer [mailto:notifications@github.com] @palladiahttps://github.com/palladia Can't approve, CI checks failed. Can you take a look? — |
Tried to rebase and push… From: Andy Schwartzmeyer [mailto:notifications@github.com] @palladiahttps://github.com/palladia Ok, go ahead and trigger another build. You'll probably want to rebase on top of a branch that contains fd782abhttps://github.com/PowerShell/PowerShell-Linux/commit/fd782abe992ff14f35819a150c54c9244bfce6ac. — |
Great! Looks like it passed; but please amend it so the commit message says what the commit does, not "New base". Would you also add a message to the commit body that explains what this fixes? Thanks! |
Comment amended. From: Andy Schwartzmeyer [mailto:notifications@github.com] Great! Looks like it passed; but please amend it so the commit message says what the commit does, not "New base". Would you also add a message to the commit body that explains what this fixes? Thanks! — |
Not seeing it. Did you force push your feature branch? |
Yes, I couldn’t push, and finally gave up and did a force. From: Andy Schwartzmeyer [mailto:notifications@github.com] Not seeing it. Did you force push your feature branch? — |
You would need to force push after amending, that's expected, but it still doesn't appear it's been amended. The commit in this PR is 866e4e6676f3d4475b2692f754f631f388dc753d, which just says "New base". |
Try again. From: Andy Schwartzmeyer [mailto:notifications@github.com] You would need to force push after amending, that's expected, but it still doesn't appear it's been amended. The commit in this PR is 866e4e6866e4e6, which just says "New base". — |
Instead of Console.ReadLine() so that arrow keys and tab-completion can be used.
3e88161
to
7e2b25e
Compare
Rebased so I can fast-forward merge the remaining PRs here in a minute, thanks! |
Merging, failed build is temporary. |
No description provided.