Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConsoleReadLine for debugger input #460

Merged
merged 2 commits into from
Feb 2, 2016
Merged

Use ConsoleReadLine for debugger input #460

merged 2 commits into from
Feb 2, 2016

Conversation

palladia
Copy link
Contributor

No description provided.

@andyleejordan
Copy link
Member

@palladia Can't approve, CI checks failed. Can you take a look?

@palladia
Copy link
Contributor Author

palladia commented Feb 1, 2016

I see this:

E: Failed to fetch http://apt-mo.trafficmanager.net/repos/dotnet/pool/main/d/dotnet-nightly/dotnet-nightly_1.0.1.001111-1_amd64.deb 404 Not Found
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command "sudo apt-get install -y dotnet-nightly" failed and exited with 100 during .
Your build has been stopped.

From: Andy Schwartzmeyer [mailto:notifications@github.com]
Sent: Friday, January 29, 2016 5:47 PM
To: PowerShell/PowerShell-Linux PowerShell-Linux@noreply.github.com
Cc: George Fleming (Insight Global) v-geflem@microsoft.com
Subject: Re: [PowerShell-Linux] Use ConsoleReadLine for debugger input (#460)

@palladiahttps://github.com/palladia Can't approve, CI checks failed. Can you take a look?


Reply to this email directly or view it on GitHubhttps://github.com//pull/460#issuecomment-177044640.

@andyleejordan
Copy link
Member

@palladia Ok, go ahead and trigger another build. You'll probably want to rebase on top of a branch that contains fd782ab.

@palladia
Copy link
Contributor Author

palladia commented Feb 1, 2016

Tried to rebase and push…

From: Andy Schwartzmeyer [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 9:47 AM
To: PowerShell/PowerShell-Linux PowerShell-Linux@noreply.github.com
Cc: George Fleming (Insight Global) v-geflem@microsoft.com
Subject: Re: [PowerShell-Linux] Use ConsoleReadLine for debugger input (#460)

@palladiahttps://github.com/palladia Ok, go ahead and trigger another build. You'll probably want to rebase on top of a branch that contains fd782abhttps://github.com/PowerShell/PowerShell-Linux/commit/fd782abe992ff14f35819a150c54c9244bfce6ac.


Reply to this email directly or view it on GitHubhttps://github.com//pull/460#issuecomment-178092274.

@andyleejordan
Copy link
Member

Great! Looks like it passed; but please amend it so the commit message says what the commit does, not "New base".

Would you also add a message to the commit body that explains what this fixes?

Thanks!

@palladia
Copy link
Contributor Author

palladia commented Feb 1, 2016

Comment amended.

From: Andy Schwartzmeyer [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 10:35 AM
To: PowerShell/PowerShell-Linux PowerShell-Linux@noreply.github.com
Cc: George Fleming (Insight Global) v-geflem@microsoft.com
Subject: Re: [PowerShell-Linux] Use ConsoleReadLine for debugger input (#460)

Great! Looks like it passed; but please amend it so the commit message says what the commit does, not "New base".

Would you also add a message to the commit body that explains what this fixes?

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/460#issuecomment-178114897.

@andyleejordan
Copy link
Member

Not seeing it. Did you force push your feature branch?

@palladia
Copy link
Contributor Author

palladia commented Feb 1, 2016

Yes, I couldn’t push, and finally gave up and did a force.

From: Andy Schwartzmeyer [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 10:45 AM
To: PowerShell/PowerShell-Linux PowerShell-Linux@noreply.github.com
Cc: George Fleming (Insight Global) v-geflem@microsoft.com
Subject: Re: [PowerShell-Linux] Use ConsoleReadLine for debugger input (#460)

Not seeing it. Did you force push your feature branch?


Reply to this email directly or view it on GitHubhttps://github.com//pull/460#issuecomment-178120867.

@andyleejordan
Copy link
Member

You would need to force push after amending, that's expected, but it still doesn't appear it's been amended.

The commit in this PR is 866e4e6676f3d4475b2692f754f631f388dc753d, which just says "New base".

@palladia
Copy link
Contributor Author

palladia commented Feb 1, 2016

Try again.

From: Andy Schwartzmeyer [mailto:notifications@github.com]
Sent: Monday, February 1, 2016 11:46 AM
To: PowerShell/PowerShell-Linux PowerShell-Linux@noreply.github.com
Cc: George Fleming (Insight Global) v-geflem@microsoft.com
Subject: Re: [PowerShell-Linux] Use ConsoleReadLine for debugger input (#460)

You would need to force push after amending, that's expected, but it still doesn't appear it's been amended.

The commit in this PR is 866e4e6866e4e6, which just says "New base".


Reply to this email directly or view it on GitHubhttps://github.com//pull/460#issuecomment-178148419.

v-alexjo and others added 2 commits February 1, 2016 17:34
Instead of Console.ReadLine() so that arrow keys and tab-completion can
be used.
@andyleejordan
Copy link
Member

Rebased so I can fast-forward merge the remaining PRs here in a minute, thanks!

@andyleejordan
Copy link
Member

Merging, failed build is temporary.

@andyleejordan andyleejordan merged commit 7e2b25e into master Feb 2, 2016
@andyleejordan andyleejordan deleted the dev/debug2 branch February 2, 2016 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants