-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert change to have SetLocation() treat wildcarded path as literal if it exists #7101
Conversation
I wonder that Travis CI failed. |
Historically, any change in 'namespaces' code has a high-risk of regressions in this high-traffic code path. |
87ee2bb
to
133e7ad
Compare
The test failure appears to be a symptom of #7032 |
@SteveL-MSFT We have a fix #7033 |
Revert "Set-Location should use path with wildcard characters if it exists instead of globbing (PowerShell#5839)" This reverts commit 7459b54.
133e7ad
to
7533ba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iSazonov merged commit didn't have a description. |
@TravisEz13 The commit has a description but multi-line - sorry that I missed it. |
PR Summary
This reverts commit 7459b54.
Left the added tests as
Pending
.Fix #6927
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.[feature]
if the change is significant or affects feature tests