Skip to content

Commit

Permalink
Fix issues caught by PoliCheck
Browse files Browse the repository at this point in the history
  • Loading branch information
andyleejordan committed Feb 3, 2021
1 parent 2a7de01 commit dd83921
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ public Task<RunspaceHandle> GetRunspaceHandleAsync(CancellationToken cancellatio

if (shouldCancelReadLine && PromptNest.IsReadLineBusy())
{
// If a ReadLine pipeline is running in the debugger then we'll hang here
// If a ReadLine pipeline is running in the debugger then we'll stop responding here
// if we don't cancel it. Typically we can rely on OnExecutionStatusChanged but
// the pipeline request won't even start without clearing the current task.
this.ConsoleReader?.StopCommandLoop();
Expand Down Expand Up @@ -1895,7 +1895,7 @@ private void PowerShellContext_RunspaceChangedAsync(object sender, RunspaceChang


// TODO: Refactor this, RunspaceDetails, PowerShellVersion, and PowerShellVersionDetails
// It's crazy that this is 4 different types.
// It's odd that this is 4 different types.
// P.S. MinifiedRunspaceDetails use to be called RunspaceDetails... as in, there were 2 DIFFERENT
// RunspaceDetails types in this codebase but I've changed it to be minified since the type is
// slightly simpler than the other RunspaceDetails.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// TODO: Fix these tests which cause the test runner to hang...
// TODO: Fix these tests which cause the test runner to stop responding...

// //
// // Copyright (c) Microsoft. All rights reserved.
Expand Down

0 comments on commit dd83921

Please sign in to comment.