Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language feature support for classes #14

Closed
kaylaerdmann opened this issue Aug 12, 2015 · 19 comments
Closed

Add language feature support for classes #14

kaylaerdmann opened this issue Aug 12, 2015 · 19 comments
Assignees
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement).

Comments

@kaylaerdmann
Copy link

kaylaerdmann commented Aug 12, 2015

The following features do not work when inside a class:

  • Parameter hints
  • Get Definition
  • Get References
  • Change Occurrences
  • Symbol search

When outside of a class all features work normally.

@kaylaerdmann kaylaerdmann added the Issue-Enhancement A feature request (enhancement). label Aug 12, 2015
@daviwil daviwil modified the milestone: 0.1.0 Aug 13, 2015
@daviwil daviwil added the Up for Grabs Will shepherd PRs. label Nov 9, 2015
@daviwil
Copy link
Contributor

daviwil commented Nov 16, 2015

Probably can't make this in for 0.1.0, will get it out soon after for 0.2.0.

@daviwil daviwil modified the milestones: 0.2.0, 0.1.0, 0.3.0 Nov 16, 2015
@daviwil daviwil changed the title Add intellisense support for classes Add language feature support for classes Dec 1, 2015
@daviwil daviwil modified the milestones: 0.3.0, Backlog Dec 31, 2015
@sgtoj
Copy link

sgtoj commented Apr 5, 2016

Is there any update on this request?

@daviwil
Copy link
Contributor

daviwil commented Apr 6, 2016

Hey Brian, not at the moment, but we'll definitely be adding it within the next few releases. Which features have you been missing the most for classes so far?

@sgtoj
Copy link

sgtoj commented Apr 7, 2016

Intelligent auto-completion and parameter hints are my number one.

@daviwil
Copy link
Contributor

daviwil commented Apr 7, 2016

Can you give an example of what you mean by intelligent auto-completion? Parameter hints for class methods are definitely coming!

@sgtoj
Copy link

sgtoj commented Apr 13, 2016

Right now, the only completion feature VS Code has when working with classes is if it see I am typing a word that already exist, it will suggest it. What I mean is: only show me the methods and constructors for the respective class type. Furthermore, it would be nice if it understood the value-types I am currently typing and show the respective signature(s) as hints or show warnings when it the object doesn't have signature the for values being pass (assuming the value was explicitly typed).

@daviwil
Copy link
Contributor

daviwil commented Apr 13, 2016

Yep, most of those things are definitely coming.

@Golosok
Copy link

Golosok commented Jul 21, 2016

Go to Definition on Method of Object would also be nice.

@daviwil
Copy link
Contributor

daviwil commented Sep 16, 2016

@kapilmb, any chance you might be able to help with this one for 0.8.0 release (early October)?

@kapilmb
Copy link

kapilmb commented Sep 30, 2016

@daviwil Sorry for getting back so late about this. Sure, you can assign this to me if you haven't started work on it already.

@daviwil
Copy link
Contributor

daviwil commented Sep 30, 2016

Assigned, thanks Kapil!

@daviwil daviwil modified the milestones: 0.10.0, April 2017 Mar 14, 2017
@Golosok
Copy link

Golosok commented Jul 25, 2017

This issue is closed for a long time, but it doesn't really work. No symbols search, no go to definition, no itellisense for classes and methods on dot sourced files...
Any updates? Can provide screenshots of things that are not working if you need examples.

@Antasik
Copy link

Antasik commented May 4, 2018

Hi.
Any news about symbol search in classes? It has been "must have" feature since Powershell 5.0.

@rkeithhill
Copy link
Contributor

IIRC PSES uses the v3 AST to cover all supported versions of PowerShell (v3-6). We've been talking about dropping support for v3/4 in the editor in the next major version of the extension. This would allow us to move to the v5 AST which recognizes class and enum. I think that would be relatively easy. If we need to continue to support back to v3 then we need a runtime swappable provider for both v3 and v5 ASTs. That's doable but would take more time.

TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this issue Feb 26, 2019
This change provides a default launch.json configuration for debugging
PowerShell scripts.
@livianaf
Copy link

livianaf commented Oct 7, 2020

Hello,
I need this functionality too. Some years ago, I created an addon for PowerShell ISE to manage group of PS scripts in a similar way folders are used with VSCode (it is in GitHub too if some one need it). I added to it the "Get definition" and "Get references" functionalities covering classes too.

Now I 'm working with VSCode to manage different language files (including PS) under the same folder and the lack of those two functionalities is so annoying that I had to implement it.

Probably it is not the best way to implement it but it works. I don't know if it is worth proposing a pull request for this change since this functionality will already be available in a next major version.

In any case, it is located in this fork if you want to review it.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Oct 7, 2020
@TylerLeonhardt
Copy link
Member

@livianaf if you would like to send a PR that would be awesome :) this is highly requested and what better time to send a PR than Hacktoberfest!

@livianaf
Copy link

Uf! I got too many errors I don't know how to manage :(

I'm sorry, this is my first PR. How can I get the detail of the errors generated by the PR checks?

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Oct 26, 2020
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Mar 30, 2021
@andyleejordan andyleejordan removed this from the Backlog milestone Aug 17, 2021
@andyleejordan
Copy link
Member

Fixed by #1984

@andyleejordan andyleejordan self-assigned this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IntelliSense Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests