Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover csproj reference to already removed project in test project PowerShellEditorServices.Test.Host.csproj #1298

Merged
merged 2 commits into from
May 30, 2020

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented May 26, 2020

No description provided.

@bergmeister bergmeister requested a review from rjmholt as a code owner May 26, 2020 11:43
@TylerLeonhardt
Copy link
Member

The PSES.Host project is a reallllly old proj before the move to Omnisharp.

It was removed/merged into PowerShellEditorServices.csproj.

Even well before that, these .Host tests were disabled because they were poor quality.

For now they serve as a reference, but they're dead tests at the moment.

@bergmeister
Copy link
Collaborator Author

bergmeister commented May 26, 2020

Should we remove the reference then? The dotnet restore error caused by it is annoying/confusing to see and I see it in VS as well.
If tests are not being run and the referenced project doesn't exist any more, I'd delete either the reference or this project.

@TylerLeonhardt
Copy link
Member

Should we remove the reference then?

Yes lets do this at least for now. We'll delete the code after I've had the time to inspect it for anything salvageable

@bergmeister bergmeister changed the title Fix csproj reference in test project PowerShellEditorServices.Test.Host.csproj Remove leftover csproj reference to already removed project in test project PowerShellEditorServices.Test.Host.csproj May 28, 2020
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 2ac8b2b into PowerShell:master May 30, 2020
@andyleejordan
Copy link
Member

LOL a year later I wasted a day determining that all the problems I was looking at weren't new...just that this code was dead and left in the repo instead of being relegated to the Git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants