Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite release signing pipeline #1408

Merged
merged 8 commits into from
Feb 3, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix issues caught by PoliCheck
  • Loading branch information
andyleejordan committed Feb 3, 2021
commit dd839211f0864e44de5d1c09e7d41251b143bcf4
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ public Task<RunspaceHandle> GetRunspaceHandleAsync(CancellationToken cancellatio

if (shouldCancelReadLine && PromptNest.IsReadLineBusy())
{
// If a ReadLine pipeline is running in the debugger then we'll hang here
// If a ReadLine pipeline is running in the debugger then we'll stop responding here
// if we don't cancel it. Typically we can rely on OnExecutionStatusChanged but
// the pipeline request won't even start without clearing the current task.
this.ConsoleReader?.StopCommandLoop();
Expand Down Expand Up @@ -1895,7 +1895,7 @@ private void PowerShellContext_RunspaceChangedAsync(object sender, RunspaceChang


// TODO: Refactor this, RunspaceDetails, PowerShellVersion, and PowerShellVersionDetails
// It's crazy that this is 4 different types.
// It's odd that this is 4 different types.
// P.S. MinifiedRunspaceDetails use to be called RunspaceDetails... as in, there were 2 DIFFERENT
// RunspaceDetails types in this codebase but I've changed it to be minified since the type is
// slightly simpler than the other RunspaceDetails.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// TODO: Fix these tests which cause the test runner to hang...
// TODO: Fix these tests which cause the test runner to stop responding...

// //
// // Copyright (c) Microsoft. All rights reserved.
Expand Down