Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR 1750 merge commit to legacy/v1.x, has additional fixes #887

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

rkeithhill
Copy link
Collaborator

This PR merges the original PR 1750 cherry-pick merge down to the legacy/v1.x branch. Turns out that merge had an additional fix to the reference code lens provider and better conversion to RFC 3986 URIs.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one question.

@TylerLeonhardt TylerLeonhardt merged commit 029a6cc into master Mar 22, 2019
@TylerLeonhardt TylerLeonhardt deleted the rkeithhill/merge-document-uri-updates branch March 22, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants