testing removing consoleecho #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeeminglyScience
approved these changes
Jul 9, 2019
| /// <summary> | ||
| /// True if we are running in PowerShell 7, false otherwise. | ||
| /// </summary> | ||
| public static bool IsPS7 { get; } = PSVersion.Major == 7; |
There was a problem hiding this comment.
Consider future proofing this somewhat by making it IsPS7OrGreater. It doesn't really matter since we aren't using it, but could save us some trouble if it gets used somewhere.
There was a problem hiding this comment.
I’d like to keep this as IsPS7. I get the idea that PS8 will maybe be on .NET 5 which might have differences… not too mention that will be years out. Plus, if PS7 makes it back into Windows in a few years, maybe there will be a day where we drop IsPS5 so this file is certainly “living” anyway.
rjmholt
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.