Add binary operators #7
Conversation
|
+1 it would be nice to be able to build this off of the official repo. |
| ), | ||
|
|
||
| binary_operator_statement: $ => seq( | ||
| $.variable, |
There was a problem hiding this comment.
I would have expected this to also allow an expression on the LHS. I see the tests only look variable binop comparisons, rather than something like (gci | % { $_.filepath }) -join "`n"
There was a problem hiding this comment.
Is changing $.variable to $._expression the only thing needed here? I can do that afterward, or I think you might be able to suggest & commit the change directly to this PR as a maintainer.
In any case, would you consider merging this? Even without this change, mostly not broken is a huge improvement over the current totally broken state :)
|
@JamesWTruher are you still able to work on this? (No pressure, just wondering if you're still active) |
|
@rjmholt can you merge this as-is? I can do an update PR afterward to fix what you mentioned. |
|
AFAIK I don't have merge privileges |
|
Oh, it looked like you had most of the git history 🙃 Do you know anyone who would? |
|
Maybe @TylerLeonhardt - are you able to merge? |
|
Alas, I do not... but @SteveL-MSFT should! |
|
No wonder there haven't been any updates in 5 years, nobody can push :) |
|
Gentle ping @SteveL-MSFT or anyone else who has permissions - could this get merged? It would be probably be good if anyone with settings access could add another maintainer (@rjmholt?) to help get this repo back up to date. And/or somebody from the TS side, @amaanq maintains a ton of grammars and might be willing to or might know who to ask. |
|
So this is basically a dead repo? |
|
@JunHaoShih @tgross35, I just shot him an email directly, asking him to assign me write permission to the repo. Hopefully at that point we can begin to unblock a few of these PRs, etc |
|
Might want to check this out, seems more maintained https://github.com/airbus-cert/tree-sitter-powershell |
|
Any luck getting in touch @cjhillbrand?
Yeah, I know that one is definitely more active. It just makes sense that the PowerShell syntax in the PowerShell org would be the de facto one, maybe effort can be pooled if a new maintainer can be added here. Or just archive this and point to that repo... but then you would still need a maintainer to update the readme here 🙂 |
No description provided.