Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples-module to use Pester 5 #3049

Closed
fflaten opened this issue Nov 3, 2020 · 1 comment · Fixed by #3214
Closed

Update examples-module to use Pester 5 #3049

fflaten opened this issue Nov 3, 2020 · 1 comment · Fixed by #3214
Labels
Area-Documentation Issue-Bug A bug to squash. Up for Grabs Will shepherd PRs.

Comments

@fflaten
Copy link
Contributor

fflaten commented Nov 3, 2020

Summary of the new feature

The example-module included in vscode-powershell uses Pester-tests that are not compatible with Pester v5. Is it time to update the examples?

Proposed technical implementation details (optional)

Update tests in example module to Pester v5-compatible code.
@ghost ghost added the Needs: Triage Maintainer attention needed! label Nov 3, 2020
@SydneyhSmith
Copy link
Collaborator

Thanks @fflaten we should update this: https://github.com/PowerShell/vscode-powershell/tree/master/examples/Tests I will mark this as up for grabs in case someone has time to get to this before we do--thanks!

@SydneyhSmith SydneyhSmith added Area-Documentation Issue-Bug A bug to squash. Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Nov 5, 2020
@nickkimbrough nickkimbrough mentioned this issue Feb 28, 2021
Merged
andyleejordan pushed a commit that referenced this issue Mar 1, 2021
@nickkimbrough
Update examples-module to use Pester 5 (#3214)
b7ab018 
This resolves #3049. Only real changes needed were wrapping the initialization in a
`BeforeAll` block and changing `Be` to `-Be`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Documentation Issue-Bug A bug to squash. Up for Grabs Will shepherd PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update examples-module to use Pester 5 nickkimbrough/vscode-powershell
2 participants
@fflaten @SydneyhSmith