Fix issue with VSCode var syntax change . to : #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTW I'm not 100% sure about the need to require vscode 1.10.0. I've reached out to Andre (cc'd you) to see what alternatives we have. Also replaced the deprecated OutDir setting with OutFiles in the extension's launch.json file.
|
It looks like this was a VSCode regression that should be fixed by a recovery build for 1.10 - microsoft/vscode#21894 So we can wait on this one until such time as we're comfortable requiring VSCode 1.10 or higher. |
|
Yep, I think 1.10.2 should be out soon enough that we won't need to fix this immediately. If it takes longer we can ship a patch update. |
|
This won't fix existing projects that have the old syntax will it? |
|
No. But there is supposed to be an update to VSCode that fixes this i.e. you will see the syntax marked as deprecated in your launch.json but it will work. |
|
Took me way too long to merge this :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW I'm not 100% sure about the need to require vscode 1.10.0. I've reached out to Andre (cc'd you) to see what alternatives we have.
Also replaced the deprecated OutDir setting with OutFiles in the extension's launch.json file.
FWIW I do get errors attaching to a PowerShell host process with VSCode 1.10 that I wasn't getting with 1.9 using 0.9.0 of the extension.