Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider exporting objects being used by SpaDES.core #389

Open
achubaty opened this issue May 9, 2024 · 1 comment
Open

consider exporting objects being used by SpaDES.core #389

achubaty opened this issue May 9, 2024 · 1 comment

Comments

@achubaty
Copy link
Collaborator

achubaty commented May 9, 2024

SpaDES.core currently has:

extractFromCache <- getFromNamespace("extractFromCache", "reproducible")
fileExt <- getFromNamespace("fileExt", "reproducible")
filePathSansExt <- getFromNamespace("filePathSansExt", "reproducible")
getDrv <- getFromNamespace("getDrv", "reproducible")
isWindows <- getFromNamespace("isWindows", "reproducible")
isAbsolutePath <- getFromNamespace("isAbsolutePath", "reproducible")
isRaster <- getFromNamespace("isRaster", "reproducible")
isSpat <- getFromNamespace("isSpat", "reproducible")
layerNamesDelimiter <- getFromNamespace("layerNamesDelimiter", "reproducible")
loadFile <- getFromNamespace("loadFile", "reproducible")
makeAbsolute <- getFromNamespace("makeAbsolute", "reproducible")
remapFilenames <- getFromNamespace("remapFilenames", "reproducible")

these should be properly exported by reproducible for use with other packages, even if they are inteded for 'developers' and not for users.

@eliotmcintire
Copy link
Contributor

I think this would be fine... but it would probably be easier if we change the function names to use the "dot" starting character so that users don't see them by default. Obviously we would need to do that in SpaDES.core also.

achubaty added a commit that referenced this issue May 17, 2024
achubaty added a commit that referenced this issue May 17, 2024
achubaty added a commit that referenced this issue May 17, 2024
achubaty added a commit to PredictiveEcology/SpaDES.core that referenced this issue May 17, 2024
achubaty added a commit to PredictiveEcology/SpaDES.core that referenced this issue May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants