chore: remove the rc provision in the helm release workflow now that prefect 3 is GA
#382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimid27
approved these changes
Sep 4, 2024
parkedwards
reviewed
Sep 4, 2024
.github/workflows/helm-release.yaml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| echo "RELEASE_VERSION=$(date +'%Y.%-m.%-d%H%M%S')" >> $GITHUB_OUTPUT | |||
| echo "PREFECT_VERSION=$(\ | |||
| git ls-remote --tags --refs --sort="v:refname" \ | |||
| https://github.com/PrefectHQ/prefect.git '[!prefect-]*.*.[!rc]' | tail -n1 | sed 's/.*\///' \ | |||
| https://github.com/PrefectHQ/prefect.git '[!prefect-]*.*.*' | tail -n1 | sed 's/.*\///' \ | |||
There was a problem hiding this comment.
these will include rcs - wonder if we should do something like this?
➜ git ls-remote --tags --refs --sort="v:refname" \
https://github.com/PrefectHQ/prefect.git '[3]*.*.[!rc]'
c40d069de2d182af586eaf7909ee77beba17fd46 refs/tags/3.0.0
There was a problem hiding this comment.
we aren't cutting any more RCs, but I guess its fine to leave as is?
There was a problem hiding this comment.
we aren't cutting any more RCs, but I guess its fine to leave as is?
right, the [!rc] just prevents them from being returned in the tag query, so we never run the risk of bundling an rc tag here
There was a problem hiding this comment.
i see, ill update!
parkedwards
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PLA-237